Skip to content

fix: add test case for syncing PTR records #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add test case for syncing PTR records #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/infoblox/infoblox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ func (p *Provider) submitChanges(changes []*infobloxChange) error {
return fmt.Errorf("could not build record: %w", err)
}
refId, logFields, err := getRefID(record)
if err != nil {
return err
if change.Action != infobloxCreate && err != nil {
return fmt.Errorf("could not get refId (%s): %w", change, err)
}
logFields["action"] = change.Action
logFields["zone"] = zone
Expand Down
81 changes: 75 additions & 6 deletions internal/infoblox/infoblox_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,9 +334,6 @@ func (client *mockIBConnector) GetObject(obj ibclient.IBObject, ref string, quer
var result []ibclient.RecordPTR
for _, object := range *client.mockInfobloxObjects {
if object.ObjectType() == "record:ptr" {
if ref == object.(*ibclient.RecordPTR).Ref {
result = append(result, *object.(*ibclient.RecordPTR))
}
if ref != "" &&
ref != object.(*ibclient.RecordPTR).Ref {
continue
Expand All @@ -345,6 +342,10 @@ func (client *mockIBConnector) GetObject(obj ibclient.IBObject, ref string, quer
AsString(obj.(*ibclient.RecordPTR).PtrdName) != AsString(object.(*ibclient.RecordPTR).PtrdName) {
continue
}
if AsString(obj.(*ibclient.RecordPTR).Ipv4Addr) != "" &&
AsString(obj.(*ibclient.RecordPTR).Ipv4Addr) != AsString(object.(*ibclient.RecordPTR).Ipv4Addr) {
continue
}
if !strings.Contains(req.queryParams, fmt.Sprintf("name:%s", AsString(object.(*ibclient.RecordPTR).Name))) {
if !strings.Contains(req.queryParams, fmt.Sprintf("zone:%s", object.(*ibclient.RecordPTR).Zone)) {
continue
Expand All @@ -369,9 +370,13 @@ func (client *mockIBConnector) GetObject(obj ibclient.IBObject, ref string, quer
}

func (client *mockIBConnector) DeleteObject(ref string) (refRes string, err error) {
re := regexp.MustCompile(`([^/]+)/[^:]+:([^/]+)/default`)
re := regexp.MustCompile(`^([^/]+)/[^:]+:([^/]+)/default$`)
result := re.FindStringSubmatch(ref)

if len(result) < 3 {
return "", fmt.Errorf("invalid reference format: %s", ref)
}

switch result[1] {
case "record:a":
var records []ibclient.RecordA
Expand All @@ -384,7 +389,7 @@ func (client *mockIBConnector) DeleteObject(ref string) (refRes string, err erro
endpoint.NewEndpoint(
*record.Name,
endpoint.RecordTypeA,
"",
*record.Ipv4Addr,
),
)
}
Expand Down Expand Up @@ -444,7 +449,7 @@ func (client *mockIBConnector) DeleteObject(ref string) (refRes string, err erro
endpoint.NewEndpoint(
*record.PtrdName,
endpoint.RecordTypePTR,
"",
*record.Ipv4Addr,
),
)
}
Expand Down Expand Up @@ -855,6 +860,70 @@ func TestInfobloxApplyChanges(t *testing.T) {
validateEndpoints(t, client.updatedEndpoints, []*endpoint.Endpoint{})
}

// TestInfobloxApplyChangesPoluted tests the behavior of the Infoblox provider
// when handling changes to DNS records, specifically in cases where PTR records
// are either missing or stale from previous runs.
//
// Test Cases:
// 1. ptrexists.example.com:
// - A previous run left a stale PTR record pointing to an outdated IP address.
// - The test expects that:
// - A new A record is created with the correct IP address.
// - A corresponding new PTR record is created.
// - The old stale PTR record is removed.
//
// 2. ptrmissing.example.com:
// - For unknown reasons, a PTR record is missing from Infoblox.
// - The test expects that:
// - A new PTR record is created to restore consistency.
func TestInfobloxApplyChangesPoluted(t *testing.T) {
client := mockIBConnector{
mockInfobloxZones: &[]ibclient.ZoneAuth{
createMockInfobloxZone("example.com"),
createMockInfobloxZone("1.2.3.0/24"),
},
mockInfobloxObjects: &[]ibclient.IBObject{
createMockInfobloxObjectWithZone("ptrexists.example.com", endpoint.RecordTypePTR, "1.2.3.11", "example.com"),
createMockInfobloxObjectWithZone("ptrmissing.example.com", endpoint.RecordTypeA, "1.2.3.9", "example.com"),
},
}

providerCfg := newInfobloxProvider(endpoint.NewDomainFilter([]string{""}), provider.NewZoneIDFilter([]string{""}), "", false, true, &client)

changes := &plan.Changes{
Create: []*endpoint.Endpoint{
endpoint.NewEndpoint("ptrexists.example.com", endpoint.RecordTypeA, "1.2.3.10"),
},
UpdateOld: []*endpoint.Endpoint{
endpoint.NewEndpoint("ptrmissing.example.com", endpoint.RecordTypeA, "1.2.3.9"),
},
UpdateNew: []*endpoint.Endpoint{
endpoint.NewEndpoint("ptrmissing.example.com", endpoint.RecordTypeA, "1.2.3.8"),
},
Delete: []*endpoint.Endpoint{},
}

if err := providerCfg.ApplyChanges(context.Background(), changes); err != nil {
t.Fatal(err)
}

validateEndpoints(t, client.createdEndpoints, []*endpoint.Endpoint{
endpoint.NewEndpoint("ptrexists.example.com", endpoint.RecordTypeA, "1.2.3.10"),
endpoint.NewEndpoint("ptrexists.example.com", endpoint.RecordTypePTR, "1.2.3.10"),
endpoint.NewEndpoint("ptrmissing.example.com", endpoint.RecordTypeA, "1.2.3.8"),
endpoint.NewEndpoint("ptrmissing.example.com", endpoint.RecordTypePTR, "1.2.3.8"),
endpoint.NewEndpoint("ptrmissing.example.com", endpoint.RecordTypePTR, "1.2.3.9"), // this should be created
})

validateEndpoints(t, client.deletedEndpoints, []*endpoint.Endpoint{
endpoint.NewEndpoint("ptrmissing.example.com", endpoint.RecordTypeA, "1.2.3.9"),
endpoint.NewEndpoint("ptrmissing.example.com", endpoint.RecordTypePTR, "1.2.3.9"),
endpoint.NewEndpoint("ptrexists.example.com", endpoint.RecordTypePTR, "1.2.3.11"), // this should be deleted
})

validateEndpoints(t, client.updatedEndpoints, []*endpoint.Endpoint{})
}

func TestInfobloxApplyChangesReverse(t *testing.T) {
client := mockIBConnector{}

Expand Down
Loading