infinity value sanitized , input pattern validation and ISO fallback #70
+149
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatloaItumeleng
requested review from
Zejnilovic,
dk1844,
benedeki,
lsulak and
yruslan
as code owners
…o handle validation
…eter input column
benedeki
reviewed
Jul 23, 2025
| protected def field: TypedStructField | ||
|
|
||
|
|
||
| private def sanitizeInput(s: String): String = { |
There was a problem hiding this comment.
Why you need this function? Why you need to sanitze the strings?
| infPlusValue.map { plusValue => | ||
| when(columnWithNegativeInf === lit(plusSymbol).cast(origType), lit(plusValue).cast(origType)) | ||
| .otherwise(columnWithNegativeInf) | ||
| val validatedMinus = if (origType == DateType || origType == TimestampType) { |
There was a problem hiding this comment.
You testing same condition twice after each other.
|
|
||
|
|
||
| def replaceInfinitySymbols(column: Column)(implicit spark:SparkSession, defaults: TypeDefaults): Column = { | ||
| var resultCol = column.cast(StringType) |
There was a problem hiding this comment.
var is to be avoided in Scala
| to_date(resultCol, "yyyy-MM-dd") | ||
| ).cast(origType) | ||
| case _ => | ||
| resultCol.cast(origType) |
| origType match { | ||
| case TimestampType => | ||
| val pattern = getPattern(origType).getOrElse( | ||
| defaults.defaultTimestampTimeZone.map(_ => "yyyy-MM-dd'T'HH:mm:ss.SSSSSS").getOrElse("yyyy-MM-dd HH:mm:ss") |
There was a problem hiding this comment.
What's the point and goal of this expression?
…ult ISO pattern used if no pattern is specified and direct casting to DateType & TimestampType
|
I tried to descibe a working solution in the original ticket comment. |
… with methods isocast & origcast , and NumericParser compability retained
|
Followed algorithm logic and implemented following solution;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69 , Adds:
DateTimeParserandNumericParserfor origType