Add Get_Line function

[atalii]

Hi,

Fixes #212. Please let me know if there's anything wrong or that can be improved here.

Thanks a ton!

[atalii]

Hi @godunko, would you mind taking a look at this? No worries if not, it would just be convenient to have it upstream. Thanks!

[godunko]

Thank you for MR!

However, things is not so easy:

• text buffer might contain incomplete data, containing single CR character at the end, while CRLF sequence is enabled, in this case next read operation will process LF character as single character and not as continuation of CRLF sequence;
• text buffer might contain incomplete data of the line; or last line of the file with out line terminator;
• application might want receive lines with or without line termination sequences.

[godunko]

Should Success be set to False here?

[atalii]

You're probably right, though this is just moved code from what's already in the repo. To be honest, I'm not sure if this is the way it is for a reason that I'm missing, or if it ought to be fixed.

[atalii]

Hi, thanks for looking over this, and my apologies for the delayed response! Let me know if this addresses your comments above; I'd hope that the version I just pushed is much more correct.

In my brief testing, this worked fine, but I think that adding automatic tests would be warranted. (If you agree, I'd appreciate some guidance on how to get started using the test infrastructure you all have.)

I'm also unsure that I'm handling inheritance correctly --- I see that Get and other such methods are listed as overriding in the private section of the specification; is that what this should do as well?

Thanks again, and please let me know if there's anything I ought to change.

[godunko]

You can add test driver here

https://github.com/AdaCore/VSS/tree/master/testsuite/stream

and modify Makefile in root directory to run it. It is recommended to use

https://github.com/AdaCore/VSS/blob/master/testsuite/common/test_support.ads

for new tests.

[godunko]

Get is declared for the "parent" interface type, thus must be implemented by non-abstract tagged type. This allows to move its declaration for tagged type into private part of the specification, cleaning a bit public part.

[CLAassistant]

All committers have signed the CLA.

[atalii]

Hi,

Sorry about this late response. I took a closer look and don't think that it makes sense to implement Get_Line as an inherited method; it requires being able to look ahead one character, which might not be supported by all input streams and doesn't really work if Input_Text_Stream is implemented on some object doing unbufferred IO. Let me know if you think that's reasonable, otherwise I can add Get_Line to the interface as you suggest.

Regarding tests, is there a good way to reference a file with test data? Thanks again :)