Skip to content

Conversation

karianna
Copy link
Member

No description provided.

Copy link

netlify bot commented May 13, 2025

Deploy Preview for vibrant-hugle-19d716 ready!

Name Link
🔨 Latest commit 1f34e7a
🔍 Latest deploy log https://app.netlify.com/projects/vibrant-hugle-19d716/deploys/687836a0cf7b230008c15344
😎 Deploy Preview https://deploy-preview-1523--vibrant-hugle-19d716.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gdams
Copy link
Member

gdams commented May 13, 2025

nice refactor! I see two issues though:

  1. The release assets aren't loading on the page: https://deploy-preview-1523--vibrant-hugle-19d716.netlify.app/archive
  2. Images don't seem to be rendering for me, is it the same on your side? I think for this one you need to move all the images in src/assets into the public folder.

@karianna
Copy link
Member Author

nice refactor! I see two issues though:

  1. The release assets aren't loading on the page: https://deploy-preview-1523--vibrant-hugle-19d716.netlify.app/archive
  2. Images don't seem to be rendering for me, is it the same on your side? I think for this one you need to move all the images in src/assets into the public folder.

Yeah oddly these both work fine for me locally when running npm run dev, so I suspect a subtle deploy difference there.

@karianna
Copy link
Member Author

@gdams - I think this can go another review now. There's some CORS stuff which can stop the Adoptium API from responding but that's a local dev thing which you can work around. Would be good to re-trigger netlify but not sure how to do that just yet!

@karianna karianna marked this pull request as ready for review July 27, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants