Update additionalData definition

[gcatanese]

Update the definition of NotificationRequestItem.additionalData to expect undefined values in the map

Fix #1539

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the type definition for the additionalData property within the NotificationRequestItem to explicitly include undefined as a valid value type. This change ensures that the type system accurately reflects scenarios where additionalData keys might hold undefined values, improving type safety and preventing potential runtime issues. A new test case has also been added to validate this updated behavior.

Highlights

• Type Definition Update: The additionalData property within the NotificationRequestItem class has been updated to allow undefined as a possible value for its keys, changing its type from {[key: string]: string;} to {[key: string]: string | undefined;}.
• Test Coverage Enhancement: A new test suite has been added to notification.spec.ts to specifically verify that the additionalData map correctly handles and identifies undefined values, alongside existing and non-existing keys.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the type definition for NotificationRequestItem.additionalData to allow undefined values and adds a test to verify the change. My feedback focuses on improving the new test case for better consistency with existing tests and for clearer, more robust assertions. Overall, the change is good and addresses the intended issue.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud