Added Image constructor support #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
This PR adds support for the
Imageconstructor as described here.Since this constructor does not directly link to the
HTMLImageElementconstructor, I have added a new "constructor function" way of adding constructors to theWindowobject:DomConstructorFunctionInstancewhich stores a reference to the constructor function and calls it when Jint calls theConstructfunction.DomConstructorFunctionAttributeto decorate any methods that need to be treated as a constructor function.EngineExtensions,EngineInstanceandCreatorCacheto find any decorated constructor functions and add them to theWindowobject.WindowExtensionswhich handles theImageconstructor call and returns a newIHtmlImageElementinstance.Imageconstructor.