Skip to content

use implementation nbs as ref docs instead of separate #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025

Conversation

RensDimmendaal
Copy link
Contributor

Currently we have a separate notebook for the reference docs. I refactor things so we can use the actual notebooks that implement the plash_cli package as the reference docs just like nbdev suggests.

Copy link

gitnotebooks bot commented Aug 12, 2025

Found 3 changed notebooks. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/plash_cli/pull/60

@RensDimmendaal RensDimmendaal requested a review from ncoop57 August 12, 2025 13:11
Copy link

📖 Documentation Preview: https://plash-docs-pr-60.pla.sh

@ncoop57
Copy link
Contributor

ncoop57 commented Aug 12, 2025

image

Not sure why, but underscores in the docstrings aren't showing up properly. Besides that it looks good!

@RensDimmendaal RensDimmendaal added the enhancement New feature or request label Aug 13, 2025
@RensDimmendaal
Copy link
Contributor Author

@ncoop57

Thanks, it was a typo. fixed it.

image

@ncoop57 ncoop57 merged commit ce107f9 into main Aug 15, 2025
1 check passed
@ncoop57 ncoop57 deleted the update-ref-docs branch August 15, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants