Use MPSolver for the "daily" hydro heuristic - #3365
Closed
flomnes wants to merge 15 commits into
Closed
Conversation
The new MPSolver implementation was not setting DonneesMensuelles->ResultatsValides to indicate whether solving succeeded or failed. This caused the calling code in daily.cpp to always throw an exception since it checks this field to determine if solving succeeded. Set ResultatsValides to OUI when solver succeeds (OPTIMAL or FEASIBLE status) and NON otherwise, matching the behavior of the old SPX-based solver.
- Wrap MPSolver object in std::unique_ptr for automatic memory management - Replace if..else block with ternary operator for setting ResultatsValides
flomnes
marked this pull request as draft
January 25, 2026 23:24
flomnes
changed the title
|
Member
Author
|
Hey @flomnes, is this still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.