Add "memory" and "cpu" modules #75
Conversation
| } | ||
| } | ||
| ButtonType::Memory(memory_mode) => { | ||
| let memory_usage = get_memory_usage(); |
There was a problem hiding this comment.
Please make a common function for "button with percentage and optional icon", there seems to be a lot of duplication for Battery/Memory/Cpu
|
|
||
| fn new_memory(action: Key, memory_mode: String, theme: Option<impl AsRef<str>>) -> Button { | ||
| let image = Self::load_image("memory", theme.as_ref()); | ||
| let memory_mode = match memory_mode.as_str() { |
There was a problem hiding this comment.
Common parser for all of them? also all panic messages refer to battery
| } | ||
|
|
||
| fn new_memory(action: Key, memory_mode: String, theme: Option<impl AsRef<str>>) -> Button { | ||
| let image = Self::load_image("memory", theme.as_ref()); |
There was a problem hiding this comment.
How about using the "memory" icon for cpu, and "memory alt" for memory?
There was a problem hiding this comment.
I can't find a memory alt icon in material design icons
There was a problem hiding this comment.
| freedesktop-icons = "0.4.0" | ||
| chrono = { version = "0.4", features = ["unstable-locales"] } | ||
| udev = "0.9" | ||
| sysinfo = "0.36.1" |
There was a problem hiding this comment.
We are linux-only, and this is not expected to change ever, so why not just read /proc directly?
There was a problem hiding this comment.
Well, that would take extra work, especially for the CPU, but I could do that
| fn get_cpu_usage() -> u32 { | ||
| let mut s = System::new(); | ||
| s.refresh_cpu_usage(); | ||
| std::thread::sleep(sysinfo::MINIMUM_CPU_UPDATE_INTERVAL); |
There was a problem hiding this comment.
this probably will be changed for other reasons, but in general - absolutely not. The app is structured around an event loop, and you should not do blocking sleeps
2 participants
Changes:
Caveats: