Skip to content

add options parameter to validate #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add options parameter to validate #52

wants to merge 1 commit into from

Conversation

zoren
Copy link

@zoren zoren commented Dec 8, 2024

This fixes #51

@charlieroberts
Copy link

I lost some time not realizing validate needed to be passed WasmFeatures; this pull request and the corresponding issue are the only things that stopped me from concluding validation was broken when using shared memory. Thanks to @zoren and it should certainly be merged (and the README should be updated as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate missing optional options parameter
2 participants
@zoren @charlieroberts