-
-
Notifications
You must be signed in to change notification settings - Fork 303
feat(pack): add prettier pack #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
It would be better to do this in a separate PR
Have you tested it, per the comment you wrote in the PR desc? @azdanov |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I've tried both conform and none-ls. Seems to be working, not sure why it was so complicated before. Now it should use the defaults from each plugin:
Not sure about none-ls fully, since it doesn't have explicit true/false check 🤷♂️ @Uzaaft What do you think? EDIT: none-ls uses this under the hood: https://github.com/nvimtools/none-ls.nvim/blob/main/lua/null-ls/utils/cosmiconfig.lua So all looks golden to me |
Issue #1501
📑 Description
Extracted prettier into separate pack. I'm wondering if I should add support for other languages like html, css, yaml, json etc. Maybe via
vim.g.prettier.format_filetypes
?Still need to test it with null_ls and conform to see that it performs similar as before.
ℹ Additional Information