Use fully qualified Qt enum names in Python#4512
Open
dj-mcg wants to merge 1 commit intoAutodesk:devfrom
Open
Conversation
PyQt6 and PySide6 expose C++ enums as Python `enum.Enum`s, dropping the
shorter path that matches the namespace of the enum in C++. For
instance, where `QtEvent::Type` values are non-scoped enums in C++, e.g.
`QtEvent::Type { KeyPress }` is `QtEvent::KeyPress`. This was exposed in
PyQt5/PySide2 as `QtEvent.KeyPress` _and_ `QtEvent.Type.KeyPress` in
preparation for a switch to use Python enums. In PyQt6/PySide6 this enum
member is only available as `QtEvent.Type.KeyPress`.
This change updates all Qt enum usage in Python to use the
fully-qualified names, which is backwards-compatible with PyQt5/PySide2.
Collaborator
|
@dj-mcg Could you add a sentence in the |
seando-adsk
added
ready-for-merge
Collaborator
Author
Oh sure - will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyQt6 and PySide6 expose C++ enums as Python
enum.Enums, dropping the shorter path that matches the namespace of the enum in C++. For instance, whereQtEvent::Typevalues are non-scoped enums in C++, e.g.QtEvent::Type { KeyPress }isQtEvent::KeyPress. This was exposed in PyQt5/PySide2 asQtEvent.KeyPressandQtEvent.Type.KeyPressin preparation for a switch to use Python enums. In PyQt6/PySide6 this enum member is only available asQtEvent.Type.KeyPress.This change updates all Qt enum usage in Python to use the fully-qualified names, which is backwards-compatible with PyQt5/PySide2.