feat(core): more rules #2107
Open
feat(core): more rules #2107
+3,637
−401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippietrail
reviewed
Oct 27, 2025
| ["all of the sudden", "all of sudden", "all the sudden"], | ||
| ["all of a sudden", "all of the sudden"], | ||
| "Prefer the phrasing `all of a sudden` or `all of the sudden`.", | ||
| "Guides this expression toward `all of a sudden` or `all of the sudden`.", |
There was a problem hiding this comment.
"All of the sudden" is nonstandard. I only know it from the internet. I think it's regional but not sure from where. Plenty of discussion about it vs standard "all of a sudden" on the internet:
- https://www.merriam-webster.com/grammar/usage-of-all-of-a-sudden
- https://www.grammarly.com/blog/commonly-confused-words/all-of-a-sudden/
- https://quillbot.com/blog/common-mistakes/all-of-a-sudden/
- https://www.rd.com/article/all-of-the-sudden-vs-all-of-a-sudden/
I would think we shouldn't recommend it. But if we must we definitely should present it is less standard than "all of a sudden".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #2043 and possibly #1836
Description
Several new grammatical rules. I suggest you look through the code to see which have been added and why. The tests may prove enlightening.
How Has This Been Tested?
Additional unit tests
Checklist