Readme: Clarify that need memcache extension, not memcached
#152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two names are very similar, and it's easy for a user to assume the `memcached` extension should be installed because the plugin is named `memcached`, and the readme mostly references `memcached`.
dd32
reviewed
Dec 11, 2023
Member
dd32
left a comment
dd32
left a comment
There was a problem hiding this comment.
Personally I don't think adding (with the d) and (without d) to all instances of it is needed.
Perhaps just a FAQ Entry of "Memcache vs MemcacheD" would be enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two names are very similar, and it's easy for a user to assume the
memcachedextension should be installed because the plugin is namedmemcached, and the readme mostly referencesmemcached. That's made worse by the fact that the plugin directory moved the Installation instructions to a secondary page ~5 years ago, so the link to the extension is not as obvious as it used to be.The general changes and FAQ address #38. The FAQ also addresses #148.
Related #6 / #133. This PR won't be needed if that one is merged, but there's currently no movement there. This is a simple readme-only change, so I think it's good to do this now, and then it can be revised if that PR is merged.