Fix: screen dimming during idle/lock problems#31
Open
versenilvis wants to merge 2 commits intoAxenide:devfrom
Open
Fix: screen dimming during idle/lock problems#31versenilvis wants to merge 2 commits intoAxenide:devfrom
versenilvis wants to merge 2 commits intoAxenide:devfrom
Conversation
- Skip idle listener triggers when MprisController.isPlaying is true - Reset elapsed idle time while media plays - Prevents screen dimming/lock while watching YouTube, Spotify, etc
Contributor
Author
Contributor
Author
|
wait I found a really bad performance behavior when turn on after suspend |
Contributor
Author
this is not from my pull request, some latest commits from upstream dev branch causing this bad performance when turn on PC after suspend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related #29
What changed?
MprisController.isPlayingis trueImportant
interval: 1500, it is enough for lock screen to fully load, I tested on 500ms, it will return default brightness immediately after the screen locked. If it is more than 1.5s, we will see a small delay to return default brightness after moving our mouse. It means, after the screen is locked and the screen is at 0% brightness, if we press keyboard, it willl return your default brightness, but it needs a small delay to return after moving out mouse, this will make a really bad user experienceNote
Tested on Zen (Firefox based), tested on Brave (Chromium based) with Youtube
This PR is from latest commit of upstream dev branch ae54c8e