fix(hyprland): use synced rounding value when applying decoration#86
Open
enhulsman wants to merge 1 commit intoAxenide:mainfrom
Open
fix(hyprland): use synced rounding value when applying decoration#86enhulsman wants to merge 1 commit intoAxenide:mainfrom
enhulsman wants to merge 1 commit intoAxenide:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I noticed the Retro preset's square window borders weren't actually applying. Retro sets
roundness: 0in its theme config withsyncRoundness: true, so Hyprland should get 0px rounding for sharp corners. Instead it was still using 16px rounding, giving rounded window borders that don't match the theme at all.The issue is in
HyprlandConfig.qmlwheresyncRoundnessis called to apply the rounding to Hyprland'sdecoration:rounding. It readsConfig.hyprland.rounding(the raw Hyprland setting, always 16) instead ofConfig.hyprlandRounding(the computed property that checks thesyncRoundnessflag and uses the theme'sroundnessvalue when sync is enabled).Solution
One-line fix: use
Config.hyprlandRoundinginstead ofConfig.hyprland.roundingin thehyprctlbatch command.Config.hyprlandRoundingis already defined in Config.qml as:So when
syncRoundnessis true (as in Retro), it uses the theme'sroundness(0), and when false, it falls back to the independent Hyprland setting (16). The property was already there, it just wasn't being used in the right place.Files Changed
modules/services/HyprlandConfig.qml: useConfig.hyprlandRoundinginstead ofConfig.hyprland.roundingTesting
syncRoundness: trueand non-zeroroundness: rounding should match the theme valuesyncRoundness: falseand changehyprland.roundingmanually: should use the independent value