refactor: improve distro detection reliability in install.sh#92
Open
DatRatVS wants to merge 1 commit intoAxenide:mainfrom
Open
refactor: improve distro detection reliability in install.sh#92DatRatVS wants to merge 1 commit intoAxenide:mainfrom
DatRatVS wants to merge 1 commit intoAxenide:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The original distro detection relied solely on checking for the presence of package manager binaries (
pacman,dnf,apt) and a single NixOS-specific file. This approach had two issues:Solution
c45eec9: Rewrote
detect_distro()to use/etc/os-releaseas the primary detection method, which is the modern Linux standard and available on all major distributions. TheIDfield is matched case-insensitively against known distro families:archfedoradebiannixosThe original package manager / file-based checks are kept as a fallback for edge cases where
/etc/os-releaseis absent.Testing
Tested via Docker across 5 distributions:
ubuntu:latestdebiandebiandebian:latestdebiandebianfedora:latestfedorafedoraalmalinux:latestfedorafedoraarchlinux:latestarcharchTest Scripts
test.shdetect_distro.sh(which is a cut down snippet from originalinstall.sh)Results