Ejector changes in prep for shutdown. #67
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rumata888
reviewed
Mar 27, 2024
Contributor
Rumata888
left a comment
Rumata888
left a comment
There was a problem hiding this comment.
I don't see any issues with barretenberg or changes in the proof construction. The other stuff is more familiar to Lasse
benesjan
reviewed
Mar 28, 2024
Contributor
benesjan
left a comment
benesjan
left a comment
There was a problem hiding this comment.
I checked the Solidity stuff and all the changes look good to me.
Contributor
|
Changed some of the solidity and Jan checked my changes so should also be good from our side 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we'll merge this to master yet. Might be a hassle to make tests and things pass. May not be worth it given it's being shutdown. Or could merge to to master but we'll switch CI off anyway. Let's see.
For now the most important things to check:
processRollupin the contract for RollupProcessorV3.