Skip to content

Migrate CRA to Vite 2 #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2025
Merged

Migrate CRA to Vite 2 #326

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74827a5
Migrate CRA to Vite
carocao-msft May 27, 2025
2732675
Node version
carocao-msft May 27, 2025
d21a676
Update index.html
carocao-msft May 28, 2025
07b7cc6
Update index.html
carocao-msft May 28, 2025
724e175
Update index.html
carocao-msft May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ui-library-pstn-1-n-calling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: ./.github/workflows/ci-ui-library.yml
with:
runs-on: 'ubuntu-latest'
node-version: '16.x'
node-version: '22.x'
working-directory: './ui-library-pstn-1-n-calling'
2 changes: 1 addition & 1 deletion .github/workflows/ui-library-quickstart-composites.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: ./.github/workflows/ci-ui-library.yml
with:
runs-on: 'ubuntu-latest'
node-version: '16.x'
node-version: '22.x'
working-directory: './ui-library-quickstart-composites'
2 changes: 1 addition & 1 deletion .github/workflows/ui-library-quickstart-rooms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: ./.github/workflows/ci-ui-library.yml
with:
runs-on: 'ubuntu-latest'
node-version: '16.x'
node-version: '22.x'
working-directory: './ui-library-quickstart-rooms'
11 changes: 6 additions & 5 deletions ...ibrary-pstn-1-n-calling/public/index.html → ui-library-pstn-1-n-calling/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,25 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="Web site created using create-react-app"
/>
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
<link rel="apple-touch-icon" href="/logo192.png" />
<!--
manifest.json provides metadata used when your web app is installed on a
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
-->
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<link rel="manifest" href="/manifest.json" />
<!--
Notice the use of %PUBLIC_URL% in the tags above.
Notice the use of in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.

Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
Unlike "/favicon.ico" or "favicon.ico", "/favicon.ico" will
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
Expand All @@ -29,6 +29,7 @@
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<script type="module" src="/src/index.tsx"></script>
<!--
This HTML file is a template.
If you open it directly in the browser, you will see an empty page.
Expand Down
Loading