Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: ./.github/workflows/ci-ui-library.yml
with:
runs-on: 'ubuntu-latest'
node-version: '16.x'
node-version: '22.x'
working-directory: './ui-library-filesharing-chat-composite/app'
2 changes: 1 addition & 1 deletion .github/workflows/ui-library-filesharing-ui-components.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: ./.github/workflows/ci-ui-library.yml
with:
runs-on: 'ubuntu-latest'
node-version: '16.x'
node-version: '22.x'
working-directory: './ui-library-filesharing-ui-components/app'
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: ./.github/workflows/ci-ui-library.yml
with:
runs-on: 'ubuntu-latest'
node-version: '16.x'
node-version: '22.x'
working-directory: './ui-library-quickstart-teams-interop-meeting-chat'
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
uses: ./.github/workflows/ci-ui-library.yml
with:
runs-on: 'ubuntu-latest'
node-version: '16.x'
node-version: '22.x'
working-directory: './ui-library-starting-with-chat-stateful'
2 changes: 2 additions & 0 deletions ui-library-add-call-recording/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,5 @@ The setup allows you to debug each service separately, but requires some orchest
In either case, navigate to your app at `localhost:4280`.

In this case, the Azure Functions will be served at `localhost:7071`. You will need to expose this port publicly to be able to register it as a webhook with EventGrid.

Currently, `azure-functions-core-tools` supports up to Node.js v20. If you're using a higher version (e.g., v22), you may encounter issues such as `localhost:4280` showing a "This site can’t be reached" error.
2 changes: 1 addition & 1 deletion ui-library-add-call-recording/app/public/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"short_name": "React App",
"name": "Create React App Sample",
"name": "React App Sample",
"icons": [
{
"src": "favicon.ico",
Expand Down
3 changes: 3 additions & 0 deletions ui-library-add-call-recording/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ui-library-add-call-recording/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,8 @@
},
"dependencies": {
"typescript": "^4.5.4"
},
"engines": {
"node": "20.x"
}
}
2 changes: 1 addition & 1 deletion ui-library-click-to-call/public/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"short_name": "React App",
"name": "Create React App Sample",
"name": "React App Sample",
"icons": [
{
"src": "favicon.ico",
Expand Down
4 changes: 3 additions & 1 deletion ui-library-filesharing-chat-composite/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ This sample includes:
You need a few Azure resources before running this sample locally.

* An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/?WT.mc_id=A261C142F) .
* [Node.js](https://nodejs.org/en/) Active LTS and Maintenance LTS versions (16.x.x is recommended).
* [Node.js](https://nodejs.org/en/) Active LTS and Maintenance LTS versions (20.x.x is recommended).
* An active Communication Services resource. [Create a Communication Services resource](https://docs.microsoft.com/azure/communication-services/quickstarts/create-communication-resource).
* An identity with Chat scope. Generate an identity using the [Azure Portal](https://docs.microsoft.com/azure/communication-services/quickstarts/identity/quick-create-identity).
* [Azure Storage Account](https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview)
Expand Down Expand Up @@ -79,3 +79,5 @@ You'll need to run the client and server separately:


Navigate to your application at `localhost:4280`.

Currently, `azure-functions-core-tools` supports up to Node.js v20. If you're using a higher version (e.g., v22), you may encounter issues such as `localhost:4280` showing a "This site can’t be reached" error.
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/index.tsx"></script>
</body>
</html>
Loading