Skip to content

Lobby Call Sample #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

v-nyerkala
Copy link

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@v-nyerkala v-nyerkala requested a review from Copilot July 28, 2025 05:35
Copilot

This comment was marked as outdated.

@v-nyerkala v-nyerkala requested a review from Copilot July 28, 2025 05:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a lobby call sample application using the Azure Communication Services Call Automation SDK. The sample demonstrates how to create and manage multiple simultaneous calls and move participants between active calls in a lobby scenario.

Key Changes:

  • Creates a complete TypeScript/Express.js web application for lobby call functionality
  • Implements Azure Communication Services integration for call automation
  • Provides a web interface for testing lobby call scenarios

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tsconfig.json TypeScript configuration for ES2015 target with CommonJS modules
package.json Project dependencies including Azure Communication Services SDKs
src/app.ts Main Express application with call automation logic and event handlers
src/webpage/index.html Web interface for testing lobby call functionality
README.md Documentation with setup instructions and prerequisites
.gitignore Standard Node.js gitignore with environment and build exclusions
Comments suppressed due to low confidence (1)

callautomation-lobbycall-sample/src/app.ts:89

  • The fetch URL /TargetCallToAcsUser(Create) does not match the defined route /targetCallToAcsUser. This will result in a 404 error.
// 					participantToMove = { phoneNumber: lobbyCallerId };

@v-nyerkala v-nyerkala requested a review from v-dharmarajv July 29, 2025 09:31
@v-nyerkala v-nyerkala marked this pull request as ready for review August 4, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant