MTPNC CRD changes for NUMA-Aware Infiniband pods

[pjohnst5]

Reason for Change:
MTPNC CRD changes for NUMA-Aware pod IB device programming

The partner team will call into CNS (still discussing how in #3825) but regardless, CNS will need to pass which IB devices to use for a pod, and DNC-RC will need to pass back to CNS the programming status of said devices

[Copilot]

Pull Request Overview

This PR adds support for NUMA-aware InfiniBand pods by extending the MultitenantPodNetworkConfig CRD with InfiniBand-specific fields. The changes enable passing InfiniBand MAC addresses and tracking programming status for InfiniBand devices.

• Added IBMACs field to store InfiniBand MAC addresses for pods
• Added IBStatus field to track InfiniBand device programming status
• Created new infiniband package with Status enum for device states

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml	Updated CRD manifest to include IBMACs array and ibStatus integer field
zz_generated.deepcopy.go	Added deep copy logic for new IBMACs slice field
multitenantpodnetworkconfig.go	Added IBMACs and IBStatus fields to spec and interface structs
cns/types/infiniband/status.go	New package defining InfiniBand programming status constants

Comments suppressed due to low confidence (1)

crd/multitenancy/api/v1alpha1/zz_generated.deepcopy.go:9

• [nitpick] The import alias 'netx' is unconventional. Consider using a more standard alias like 'net' or removing the alias entirely since there's no naming conflict.

	netx "net"

[pjohnst5]

I would actually like to get #3825 ironed out before merging this

[pjohnst5]

Actually, this is ready for review
We are not dependent on #3825 for this, we will need to do this regardless how the CNS APIs are setup
I may later want to add an errorCode field into the interfaceInfo struct as well ( to be able to describe better what failed when programming a device ) but that is up to debate rn so this we know needs to be merged

[pjohnst5]

Hey @thatmattlong , are there any problems with associated outside package types in a CRD?
Mainly I'm talking about
multitenantpodnetworkconfig.go

IBMACAddresses []net.HardwareAddr `json:"IBMACAddresses,omitempty"`
...
IBStatus infiniband.Status `json:"ibStatus,omitempty"`

[pjohnst5]

Hey @thatmattlong , are there any problems with associated outside package types in a CRD?
Mainly I'm talking about

Yeah not best so I'll remove it

[pjohnst5]

/azp list

[azure-pipelines]

CI/CD Pipelines for this repository:

• Azure Container Networking PR
• NPM Conformance Tests
• CNI Release Test
• NPM Scale Test
• Cilium Scale Test
• Cilium Hubble Enablement
• ACN Network Observability E2E
• TriggerCompliantBuild

[pjohnst5]

/azp run Azure Container Networking PR

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pjohnst5]

Hold on, may want to add a UID field somewhere in the MTPNC spec to differentiate between pods that have the same name
See #3825

[pjohnst5]

Doesn't seem we'll need to add pod UID, since the MTPNC will have an ownerref to the pod that it is created for (avoiding a toctou race)

[pjohnst5]

/azp run Azure Container Networking PR

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).