ci: remove debug stack usage #4075
Open
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
requested review from
Copilot and
paulyufan2
and removed request for
paulyufan2
|
/azp run Azure Container Networking PR |
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary debug.Stack() calls from error messages in the Azure IPAM invoker and replaces them with predefined error variables for cleaner error handling.
- Removes
runtime/debugimport anddebug.Stack()calls from error messages - Introduces predefined error variables (
errNilNetworkConfig,errInvalidIPAddress) for consistent error handling - Updates error messages to use the new error variables instead of stack traces
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Azure Pipelines successfully started running 1 pipeline(s). |
MikeZappa87
approved these changes
Oct 23, 2025
behzad-mir
approved these changes
Oct 28, 2025
paulyufan2
approved these changes
Oct 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
remove debug stack usage
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Removes unnecessary
debug.Stack()callsIssue Fixed:
Requirements:
Notes: