-
Notifications
You must be signed in to change notification settings - Fork 4k
trusted signing: add filter to sign files with .cip extension #28207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for signing .cip
files alongside .bin
files in the Az.TrustedSigning module.
- Added a null-environment check with an exception in
CodeSigningServiceClient
. - Extended
InvokeCIPolicySigning.ValidateFileType
to recognize.cip
files and updated messaging. - Updated
ChangeLog.md
to document.cip
extension support.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/TrustedSigning/TrustedSigning/Models/CodeSigningServiceClient.cs | Throw ArgumentException when context.Environment is null |
src/TrustedSigning/TrustedSigning/Commands/InvokeCIPolicySigning.cs | Accept .cip extension in ValidateFileType and adjust warning text |
src/TrustedSigning/TrustedSigning/ChangeLog.md | Added entry for .cip support in upcoming release |
Comments suppressed due to low confidence (2)
src/TrustedSigning/TrustedSigning/Commands/InvokeCIPolicySigning.cs:145
- There should be automated tests covering
.cip
extension handling inValidateFileType
to ensure new behavior is verified.
string fileExtension = System.IO.Path.GetExtension(fullInPath);
src/TrustedSigning/TrustedSigning/Commands/InvokeCIPolicySigning.cs:147
- [nitpick] The indentation for the second OR condition is inconsistent. Align it under the first
string.Equals
for better readability.
string.Equals(fileExtension, ".cip", StringComparison.OrdinalIgnoreCase))
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
This PR expands the Az.TrustedSigning module to also support Signing .cip files along with .bin files for signing ci policies.
cc: @janielMartell
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.