[StorageCache] Adding support for Import, AutoExport and AutoImport HSM Jobs #28524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Import, AutoExport, and AutoImport HSM Jobs to the Azure PowerShell StorageCache module. The changes introduce comprehensive cmdlet support for managing these job types within AML filesystems.
- Adds complete CRUD operations for Import, AutoImport, and AutoExport jobs
- Updates existing AML filesystem cmdlets with new parameters for root squash settings and import prefixes
- Expands module exports to include new job management cmdlets
Reviewed Changes
Copilot reviewed 70 out of 76 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Update-AzStorageCacheImportJob.md | Help documentation for updating import job instances |
| Update-AzStorageCacheAutoImportJob.md | Help documentation for updating auto import job instances |
| Update-AzStorageCacheAutoExportJob.md | Help documentation for updating auto export job instances |
| Update-AzStorageCacheAmlFileSystem.md | Enhanced help with new root squash setting parameters |
| Remove-AzStorageCacheImportJob.md | Help documentation for deleting import jobs |
| Remove-AzStorageCacheAutoImportJob.md | Help documentation for deleting auto import jobs |
| Remove-AzStorageCacheAutoExportJob.md | Help documentation for deleting auto export jobs |
| New-AzStorageCacheImportJob.md | Help documentation for creating import jobs |
| New-AzStorageCacheAutoImportJob.md | Help documentation for creating auto import jobs |
| New-AzStorageCacheAutoExportJob.md | Help documentation for creating auto export jobs |
| New-AzStorageCacheAmlFileSystem.md | Enhanced help with new root squash and import prefix parameters |
| Get-AzStorageCacheImportJob.md | Help documentation for retrieving import jobs |
| Get-AzStorageCacheAutoImportJob.md | Help documentation for retrieving auto import jobs |
| Get-AzStorageCacheAutoExportJob.md | Help documentation for retrieving auto export jobs |
| Az.StorageCache.md | Updated module overview with all new cmdlets |
| Az.StorageCache.psd1 | Module manifest updated with new functions and dependency versions |
| StorageCache.sln | Solution file project reference updates |
| localEnv.json | Test environment configuration |
| env.json | Test environment configuration updates |
| Update-AzStorageCacheImportJob.Tests.ps1 | Test scaffolding for import job updates |
| Update-AzStorageCacheAutoImportJob.Tests.ps1 | Comprehensive test coverage for auto import job updates |
| Update-AzStorageCacheAutoImportJob.Recording.json | Test recording data for auto import job tests |
| Update-AzStorageCacheAutoExportJob.Tests.ps1 | Comprehensive test coverage for auto export job updates |
Comment on lines
57
to
60
| Update-AzStorageCacheImportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myimportjob' -ResourceGroupName 'myresourcegroup' -ImportPrefix @('/newpath1', '/newpath2') | ||
| ``` | ||
|
|
||
| Updates the specified import job with new import prefixes. |
There was a problem hiding this comment.
The example refers to an -ImportPrefix parameter that is not documented in the PARAMETERS section. Either add the parameter documentation or update the example to use documented parameters like -AdminStatus or -Tag.
Suggested change
| Update-AzStorageCacheImportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myimportjob' -ResourceGroupName 'myresourcegroup' -ImportPrefix @('/newpath1', '/newpath2') | |
| ``` | |
| Updates the specified import job with new import prefixes. | |
| Update-AzStorageCacheImportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myimportjob' -ResourceGroupName 'myresourcegroup' -AdminStatus 'Active' -Tag @{Environment='Production'} |
Updates the specified import job by setting the administrative status to 'Active' and adding a tag.
Copilot uses AI. Check for mistakes.
Comment on lines
55
to
60
| ### Example 1: Update an auto import job | ||
| ```powershell | ||
| Update-AzStorageCacheAutoImportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myautoimportjob' -ResourceGroupName 'myresourcegroup' -AutoImportPrefix @('/newpath1', '/newpath2') | ||
| ``` | ||
|
|
||
| Updates the specified auto import job with new auto import prefixes. |
There was a problem hiding this comment.
The example refers to an -AutoImportPrefix parameter that is not documented in the PARAMETERS section. Either add the parameter documentation or update the example to use documented parameters like -AdminStatus or -Tag.
Suggested change
| ### Example 1: Update an auto import job | |
| ```powershell | |
| Update-AzStorageCacheAutoImportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myautoimportjob' -ResourceGroupName 'myresourcegroup' -AutoImportPrefix @('/newpath1', '/newpath2') | |
| ``` | |
| Updates the specified auto import job with new auto import prefixes. | |
| ### Example 1: Update the administrative status of an auto import job | |
| ```powershell | |
| Update-AzStorageCacheAutoImportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myautoimportjob' -ResourceGroupName 'myresourcegroup' -AdminStatus 'Disable' |
Updates the specified auto import job by disabling it.
Copilot uses AI. Check for mistakes.
Comment on lines
55
to
60
| ### Example 1: Update an auto export job | ||
| ```powershell | ||
| Update-AzStorageCacheAutoExportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myautoexportjob' -ResourceGroupName 'myresourcegroup' -AutoExportPrefix @('/newpath1') | ||
| ``` | ||
|
|
||
| Updates the specified auto export job with a new auto export prefix. |
There was a problem hiding this comment.
The example refers to an -AutoExportPrefix parameter that is not documented in the PARAMETERS section. Either add the parameter documentation or update the example to use documented parameters like -AdminStatus or -Tag.
Suggested change
| ### Example 1: Update an auto export job | |
| ```powershell | |
| Update-AzStorageCacheAutoExportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myautoexportjob' -ResourceGroupName 'myresourcegroup' -AutoExportPrefix @('/newpath1') | |
| ``` | |
| Updates the specified auto export job with a new auto export prefix. | |
| ### Example 1: Update the administrative status of an auto export job | |
| ```powershell | |
| Update-AzStorageCacheAutoExportJob -AmlFilesystemName 'myamlfilesystem' -Name 'myautoexportjob' -ResourceGroupName 'myresourcegroup' -AdminStatus 'Disable' |
Updates the specified auto export job by disabling it.
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Aman-Jain-14
force-pushed
the
dev/amajai/main-storagecache_support_for_import_autoexport_autoimport
branch
from
a2d68ac to
796d70c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@VeryEarly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for Import, AutoExport and AutoImport HSM Jobs
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
[Y] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.