Skip to content

Conversation

blueww
Copy link
Member

@blueww blueww commented Sep 18, 2025

Description

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1518

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 09:01
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for NFS symbolic link functionality in Azure Storage by implementing two new cmdlets for creating and getting symbolic links in NFS file shares. The changes include updating Azure Storage SDK versions to support the new symbolic link APIs.

Key changes include:

  • Added New-AzStorageFileSymbolicLink cmdlet for creating symbolic links
  • Added Get-AzStorageFileSymbolicLink cmdlet for retrieving symbolic link properties
  • Updated Azure Storage SDK dependencies to enable symbolic link functionality

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/Storage/Storage/Storage.csproj Updates Azure Storage package versions to support symbolic link APIs
src/Storage/Storage/File/Cmdlet/NewAzureStorageFileSymbolicLink.cs Implements cmdlet for creating NFS symbolic links with metadata and POSIX properties
src/Storage/Storage/File/Cmdlet/GetAzureStorageFileSymbolicLink.cs Implements cmdlet for retrieving symbolic link properties and target paths
src/Storage/Storage/Common/AzureStorageFile.cs Extends AzureStorageFile class to support symbolic link information
src/Storage/Storage.common/Storage.common.csproj Updates Azure.Storage.Files.Shares package version
src/Storage/Storage.Management/help/*.md Adds comprehensive documentation for both new cmdlets
src/Storage/Storage.Management/Az.Storage.md Updates module documentation to include new symbolic link cmdlets
src/Storage/Storage.Management/ChangeLog.md Documents the new symbolic link functionality
src/Storage/Storage.Management/Az.Storage.psd1 Exports the new cmdlets
src/Storage/Storage.Management.Test/Storage.Management.Test.csproj Updates test project package versions

@blueww blueww force-pushed the nfsstg98 branch 2 times, most recently from be64a58 to a79b126 Compare September 18, 2025 09:30
@blueww
Copy link
Member Author

blueww commented Sep 23, 2025

@VeryEarly

Feel free to let me know if anything need change before the PR can be merged.

@blueww
Copy link
Member Author

blueww commented Sep 25, 2025

@VeryEarly

As it's close to the code complete date, please help to review / merge it.
Feel free to ping me if any change needed.

@VeryEarly VeryEarly merged commit fefef36 into Azure:main Sep 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants