Revert "Enhance Get-AzMigrateServerMigrationStatus cmdlet to support -Expedit…" #28594
Conversation
…-Expedit…" This reverts commit 26a72c5.
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This is a revert pull request that undoes the enhancement of the Get-AzMigrateServerMigrationStatus cmdlet that had added support for the -Expedite parameter. The revert removes the expedite functionality and associated code changes while restoring the previous version's behavior and examples.
- Removes the
-Expediteparameter fromGet-AzMigrateServerMigrationStatuscmdlet - Updates help documentation, examples, and test files to reflect the parameter removal
- Reverts version numbers and project file references to previous states
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| Multiple help/*.md files | Remove references to -Expedite parameter and related examples from documentation |
| Get-AzMigrateServerMigrationStatus.ps1 | Remove -Expedite parameter definition and expedite-related functionality |
| ChangeLog.md | Remove changelog entry about expedite parameter enhancement |
| Various project files | Revert version numbers, timestamps, and project references |
| [Parameter(ParameterSetName = 'GetByPrioritiseServer', Mandatory)] | ||
| Specifies the display name of the replicating machine. |
There was a problem hiding this comment.
The documentation contains orphaned parameter references to 'GetByPrioritiseServer' parameter set which no longer exists after the expedite functionality was removed. These commented lines should be completely removed from the documentation.
Copilot uses AI. Check for mistakes.
| ```yaml | ||
| Type: System.String | ||
| Parameter Sets: GetByMachineName, GetHealthByMachineName, GetByPrioritiseServer | ||
| Parameter Sets: GetByMachineName, GetHealthByMachineName |
There was a problem hiding this comment.
The documentation contains orphaned parameter references to 'GetByPrioritiseServer' parameter set which no longer exists after the expedite functionality was removed. These commented lines should be completely removed from the documentation.
Copilot uses AI. Check for mistakes.
| [Parameter(ParameterSetName = 'GetByPrioritiseServer', Mandatory)] | ||
| Specifies the Azure Migrate project in the current subscription. |
There was a problem hiding this comment.
The documentation contains orphaned parameter references to 'GetByPrioritiseServer' parameter set which no longer exists after the expedite functionality was removed. These commented lines should be completely removed from the documentation.
Copilot uses AI. Check for mistakes.
| [Parameter(ParameterSetName = 'GetByPrioritiseServer', Mandatory)] | ||
| Specifies the Resource Group of the Azure Migrate Project in the current subscription. |
There was a problem hiding this comment.
The documentation contains orphaned parameter references to 'GetByPrioritiseServer' parameter set which no longer exists after the expedite functionality was removed. These commented lines should be completely removed from the documentation.
Copilot uses AI. Check for mistakes.
| [Parameter(ParameterSetName = 'GetHealthByMachineName', Mandatory)] | ||
| [Parameter(ParameterSetName = 'GetByApplianceName', Mandatory)] | ||
| [Parameter(ParameterSetName = 'GetByPrioritiseServer', Mandatory)] | ||
| #[Parameter(ParameterSetName = 'GetByPrioritiseServer', Mandatory)] |
There was a problem hiding this comment.
The code contains commented-out sections related to the removed expedite functionality. These commented lines should be completely removed rather than left as comments to maintain clean code and avoid confusion.
Copilot uses AI. Check for mistakes.
| [Parameter(ParameterSetName = 'GetByMachineName', Mandatory)] | ||
| [Parameter(ParameterSetName = 'GetHealthByMachineName', Mandatory)] | ||
| [Parameter(ParameterSetName = 'GetByPrioritiseServer', Mandatory)] | ||
| #[Parameter(ParameterSetName = 'GetByPrioritiseServer', Mandatory)] |
There was a problem hiding this comment.
The code contains commented-out sections related to the removed expedite functionality. These commented lines should be completely removed rather than left as comments to maintain clean code and avoid confusion.
Copilot uses AI. Check for mistakes.
| $null = $PSBoundParameters.Remove('ApplianceName') | ||
| $null = $PSBoundParameters.Remove('Health') | ||
| $null = $PSBoundParameters.Remove('Expedite') | ||
| #$null = $PSBoundParameters.Remove('Expedite') |
There was a problem hiding this comment.
The code contains commented-out sections related to the removed expedite functionality. These commented lines should be completely removed rather than left as comments to maintain clean code and avoid confusion.
Copilot uses AI. Check for mistakes.
| if ($addedMachines.ContainsKey($MigrationItem.MachineName)) { | ||
| continue | ||
| } | ||
| <#if( $parameterSet -eq "GetByPrioritiseServer") { |
There was a problem hiding this comment.
The code contains commented-out sections related to the removed expedite functionality. These commented lines should be completely removed rather than left as comments to maintain clean code and avoid confusion.
Copilot uses AI. Check for mistakes.
| Write-Host "3. Increase the Network bandwidth available for appliances so that upload speeds can increase." | ||
| Write-Host "4. Increase the NFC buffer size to increase the upload speed." | ||
| Write-Host "5. Perform storage Vmotion on server $($ReplicationMigrationItem.MachineName)." | ||
| }#> |
There was a problem hiding this comment.
The code contains commented-out sections related to the removed expedite functionality. These commented lines should be completely removed rather than left as comments to maintain clean code and avoid confusion.
Copilot uses AI. Check for mistakes.
| # $op = $output.Add("To check expedite the operation of a server use the command") | ||
| # $op = $output.Add("Get-AzMigrateServerMigrationStatus -ProjectName <String> -ResourceGroupName <String> -MachineName <String> -Expedite`n") |
There was a problem hiding this comment.
The code contains commented-out sections related to the removed expedite functionality. These commented lines should be completely removed rather than left as comments to maintain clean code and avoid confusion.
| # $op = $output.Add("To check expedite the operation of a server use the command") | |
| # $op = $output.Add("Get-AzMigrateServerMigrationStatus -ProjectName <String> -ResourceGroupName <String> -MachineName <String> -Expedite`n") |
Copilot uses AI. Check for mistakes.
Reverts #28537