[RecoveryServices.Backup] [Ignite] Added support for vault soft delete #28620
Conversation
Added ARG SDK Added support for vault soft delete - Get soft deleted vault - Undelete softdeleted vault - Get deleted backup items in a soft deleted vault using ARG
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for vault soft delete functionality to the Azure Recovery Services module. The soft delete feature allows vaults to be recoverable for a retention period after deletion rather than being permanently removed.
Key changes include:
- Addition of three new cmdlets for managing soft-deleted vaults and retrieving their backup items
- Implementation of Azure Resource Graph (ARG) integration for querying soft-deleted vault backup items
- Extended model classes to support soft-deleted vault scenarios
Reviewed Changes
Copilot reviewed 29 out of 110 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| UndoAzRecoveryServicesVaultDeletion.cs | Implements cmdlet to restore soft-deleted vaults to active state |
| GetAzureRmRecoveryServicesSoftDeletedVault.cs | Implements cmdlet to retrieve soft-deleted vaults by location and filters |
| GetAzureRmRecoveryServicesSoftDeletedVaultBackupItem.cs | Implements cmdlet to query backup items from soft-deleted vaults using ARG |
| PSRecoveryServicesVaultClient.cs | Adds client methods for soft-deleted vault operations |
| ConversionHelpers.cs | Adds conversion logic for ARG responses to backup item models |
| Multiple model files | Defines soft-deleted vault item classes extending existing backup item types |
| Help documentation | Provides comprehensive cmdlet documentation and usage examples |
Comments suppressed due to low confidence (1)
src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVaultBackupItem.md:1
- The description should be 'Gets backup items from soft-deleted Recovery Services vaults' (plural) to match the cmdlet's functionality of querying multiple vaults.
---
| /// Undeletes a soft deleted Azure Recovery Services Vault. | ||
| /// </summary> | ||
| [Cmdlet("Undo", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "RecoveryServicesVaultDeletion", SupportsShouldProcess = true)] | ||
| [OutputType(typeof(Object))] // chck: ServeClientModel.OperationStatus |
There was a problem hiding this comment.
The comment contains a typo 'chck' which should be 'check'.
Copilot uses AI. Check for mistakes.
|
|
||
| WriteVerbose($"Undelete operation completed for vault '{this.Name}'"); | ||
|
|
||
| this.WriteObject(new ARSSoftDeletedVault(undeleteResult)); // chck with Rishav what should be the output type here. |
There was a problem hiding this comment.
The comment contains a typo 'chck' which should be 'check'.
| this.WriteObject(new ARSSoftDeletedVault(undeleteResult)); // chck with Rishav what should be the output type here. | |
| this.WriteObject(new ARSSoftDeletedVault(undeleteResult)); // check with Rishav what should be the output type here. |
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -0,0 +1,24 @@ | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
There was a problem hiding this comment.
please delete this file
|
|
||
| ### Example 1: Get all soft-deleted vaults in a location | ||
| ```powershell | ||
| PS C:\> Get-AzRecoveryServicesSoftDeletedVault -Location "westus" |
There was a problem hiding this comment.
please delete "PS C:>" in all examples
rerecording the failed tests |
| --> | ||
| ## Upcoming Release | ||
| * Added Cross region restore support for new region - eastus3. | ||
| * Added support for vault soft delete feature - Get soft deleted vault, Undelete softdeleted vault, Get deleted backup items in a soft deleted vault using ARG. |
There was a problem hiding this comment.
| * Added support for vault soft delete feature - Get soft deleted vault, Undelete softdeleted vault, Get deleted backup items in a soft deleted vault using ARG. | |
| * Added support for vault soft delete feature - Get soft deleted vault, undelete soft deleted vault, get deleted backup items in a soft deleted vault using ARG. |
| --- | ||
| external help file: Microsoft.Azure.PowerShell.Cmdlets.RecoveryServices.dll-Help.xml | ||
| Module Name: Az.RecoveryServices | ||
| online version: |
There was a problem hiding this comment.
Please fill in online version for new cmdlets. E.g. https://learn.microsoft.com/powershell/module/az.recoveryservices/get-azrecoveryservicessoftdeletedvault
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
Added support for vault soft delete
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.