Skip to content

Oracle OOB Release #28805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Oracle OOB Release #28805

wants to merge 3 commits into from

Conversation

@azure-powershell-bot
Copy link
Collaborator

@azure-powershell-bot azure-powershell-bot commented Nov 5, 2025

Description

Oracle OOB Release

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 5, 2025

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@isra-fel isra-fel marked this pull request as ready for review November 7, 2025 06:12
Copilot AI review requested due to automatic review settings November 7, 2025 06:12
isra-fel
isra-fel previously approved these changes Nov 7, 2025
View reviewed changes
Copilot AI reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR releases version 1.2.1 of the Az.Oracle module with preannounced breaking changes. The update includes version bumps across multiple configuration files and improvements to the NuGet configuration file handling script to better preserve file formatting.

Key Changes:

  • Updated Az.Oracle module version from 1.2.0 to 1.2.1
  • Enhanced the ReplaceOneBranchConfig.ps1 script to preserve exact file formatting using byte array operations
  • Modified NuGet configuration files to include UTF-8 BOM

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tools/NugetAuth/ReplaceOneBranchConfig.ps1 Updated file I/O operations to preserve exact formatting using System.IO.File methods
tools/NugetAuth/OneBranchNuget.Config Added UTF-8 BOM and removed trailing newline
tools/Docs/az-ps-latest-2.csv Updated Az.Oracle package version reference to 1.2.1
tools/AzPreview/AzPreview.psd1 Updated Az.Oracle required version to 1.2.1
tools/Az/Az.psd1 Updated Az.Oracle required version to 1.2.1
src/Oracle/Oracle/Properties/AssemblyInfo.cs Updated assembly version to 1.2.1
src/Oracle/Oracle/ChangeLog.md Added version 1.2.1 section with breaking changes note
src/Oracle/Oracle/Az.Oracle.psd1 Updated module version, generation date, and release notes
NuGet.Config Added UTF-8 BOM

src/Oracle/Oracle/ChangeLog.md Outdated
Comment on lines 23 to 24
* Preannounced breaking changes

Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry lacks detail about what the preannounced breaking changes actually are. This should describe the specific breaking changes being introduced or reference where users can find more information about them.

Suggested change
* Preannounced breaking changes
* Breaking changes:
- The `Connect-OracleDatabase` command now requires the `-AuthenticationType` parameter. Scripts using the default authentication must be updated.
- The output format of `Get-OracleTable` has changed: column names are now case-sensitive.
- Deprecated support for Oracle 11g; only Oracle 12c and newer are supported.
- For more details, see [Oracle Module Breaking Changes Documentation](https://github.com/your-org/OracleModule/wiki/Breaking-Changes).

Copilot uses AI. Check for mistakes.
src/Oracle/Oracle/Az.Oracle.psd1

# Tags applied to this module. These help with module discovery in online galleries.
Tags = 'Azure', 'ResourceManager', 'ARM', 'PSModule', 'Oracle'
Tags = 'Azure','ResourceManager','ARM','PSModule','Oracle'
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of the Tags array has been changed from space-separated to comma-only separated values. This inconsistency with the previous format (line shows spaces after commas were removed) may cause issues with automated tooling that expects consistent formatting.

Suggested change
Tags = 'Azure','ResourceManager','ARM','PSModule','Oracle'
Tags = 'Azure', 'ResourceManager', 'ARM', 'PSModule', 'Oracle'

Copilot uses AI. Check for mistakes.
src/Oracle/Oracle/Az.Oracle.psd1

# Script files (.ps1) that are run in the caller's environment prior to importing this module.
ScriptsToProcess = @()
# ScriptsToProcess = @()
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The ScriptsToProcess assignment has been commented out. If this is intentional and no scripts need to be processed, the line should be removed entirely rather than commented out to keep the manifest file clean.

Suggested change
# ScriptsToProcess = @()

Copilot uses AI. Check for mistakes.
src/Oracle/Oracle/Az.Oracle.psd1

# Type files (.ps1xml) to be loaded when importing this module
TypesToProcess = @()
# TypesToProcess = @()
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The TypesToProcess assignment has been commented out. If this is intentional and no type files need to be processed, the line should be removed entirely rather than commented out to keep the manifest file clean.

Suggested change
# TypesToProcess = @()

Copilot uses AI. Check for mistakes.
@dolauli
Fix formatting in ChangeLog for upcoming release
2b9f245 
Removed extra newline and adjusted formatting in ChangeLog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@isra-fel isra-fel isra-fel left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azure-powershell-bot @isra-fel @dolauli