Skip to content

[DNM] Validate typespec-azure#2974 #36014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AlitzelMendez
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

hahahahahaiyiwen and others added 11 commits July 17, 2025 09:35
* [Monitor Ingestion] Add typespec files

Signed-off-by: Paul Van Eck <[email protected]>

* Remove ServiceTraits

Signed-off-by: Paul Van Eck <[email protected]>

* Adjustments

Signed-off-by: Paul Van Eck <[email protected]>

* Syntax updates

Signed-off-by: Paul Van Eck <[email protected]>

* Updates

Signed-off-by: Paul Van Eck <[email protected]>

* Updating tspconfig.yaml

* Updating tspconfig.yaml

* test update

* Updating tspconfig.yaml

* Updating tspconfig.yaml

* test update

* test updates

* test updates

* test updates

* test updates

* test updates

* add customization class to tspconfig

* remove error in tspconfig

* Restoring deleted file

* Updating tspconfig

* Updating formatting

---------

Signed-off-by: Paul Van Eck <[email protected]>
Co-authored-by: Paul Van Eck <[email protected]>
* [Monitor Query] Add TypeSpec for Logs Query

Signed-off-by: Paul Van Eck <[email protected]>

* Create custom client

Only generate operations we care about.

Signed-off-by: Paul Van Eck <[email protected]>

* Adjustments

Signed-off-by: Paul Van Eck <[email protected]>

* Make service version as path param

* suppress missing api version warning

* Updates

Signed-off-by: Paul Van Eck <[email protected]>

* Rename examples

Signed-off-by: Paul Van Eck <[email protected]>

* Recompile autorest with examples

Signed-off-by: Paul Van Eck <[email protected]>

* Add API version docstring

Signed-off-by: Paul Van Eck <[email protected]>

* Misc updates

Signed-off-by: Paul Van Eck <[email protected]>

* Move generated swagger

Signed-off-by: Paul Van Eck <[email protected]>

* Add readme to pass avocado check

Signed-off-by: Paul Van Eck <[email protected]>

* Change rows type

Signed-off-by: Paul Van Eck <[email protected]>

* Add autorest suppressions

Signed-off-by: Paul Van Eck <[email protected]>

* Rename directory

Signed-off-by: Paul Van Eck <[email protected]>

---------

Signed-off-by: Paul Van Eck <[email protected]>
Co-authored-by: Srikanta <[email protected]>
* Copy files from stable/2025-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-07-15

Updated the API version from stable/2025-03-01 to stable/2025-07-15.

* Added tag for 2025-07-15 in readme file

* creates a new stable version for the enforcement endpoints

* Adds the enforcement examples

* adds GroupQuotaUsages folder

* Adds enforcement definitions

* Modifies the api version in the enforcement examples

* adds proper api version for usages example

* changes the retry after type and fixes typos

* changes another description

* renames GroupQuotasEnforcementResponse to GroupQuotaEnforcementStatus

* formats object

* Changes GroupQuotaEnforcementResponse to GroupQuotaEnforcementStatus. reverts unneccessary change in 2023-06-01 preview

* ran prettier on 2023-06-01-preview for prettier check violation

* changes object definition  in preview version as well

* resolves retry after issue

* reverts the preview file objects
* [Monitor Query Logs] Add Java customizations

* format
Copy link

openapi-pipeline-app bot commented Jul 18, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The suppressions added to the AutoRest config files (README.mds) require review. Refer to step 1 in the PR workflow diagram, or to step 3, depending on the kind of suppression you did.

Copy link

openapi-pipeline-app bot commented Jul 18, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Jul 18, 2025
@@ -36,5 +36,6 @@ interface Apis {
@doc("Deletes specified API.")
delete is ArmResourceDeleteSync<Api>;
@doc("Returns a collection of APIs.")
@list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we don't need this since we should have this @list since we are using the standard template.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so but the template also lets you define a custom response which in theory could be not pageable so need to double check that is not being misued.

@timotheeguerin timotheeguerin changed the base branch from main to typespec-next July 23, 2025 22:02
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jul 23, 2025
@timotheeguerin
Copy link
Member

restarted in a new pr #36153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. data-plane resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.