Skip to content

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Jul 19, 2025

First attempt. I don't like adding the options bag to the filters, it also makes them always require a lambda to use.

To make the filters most reusable, I thinke we need to decompose them, to their minimal parts, so callers can decide if they need to combine checks with startsWithSpecification(repoRoot).

It would also be better, if we could filter the call to getChangedFiles() to the spec folder initially, when it makes sense. This way, maybe the filters never need to check for "starts with spec" vs "spec folder nested under test dir".

Copy link

openapi-pipeline-app bot commented Jul 19, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named TypeSpec Requirement has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Jul 19, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@mikeharder mikeharder changed the title [chagned-files] return absolute platform paths [changed-files] return absolute platform paths Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant