Skip to content

Fix the definition of CustomCredential to match actual service response #37310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Fix the definition of CustomCredential to match actual service response #37310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions specification/ai/Azure.AI.Projects/client.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,6 @@ using Azure.ClientGenerator.Core;
// More accurate naming
@@clientName(Azure.AI.Projects.AssetCredentialResponse, "DatasetCredential");

// In Python, the emitter changes "keys" to "keys_property", since there is already
// a "keys" method in the generated code due to usage of MutableMapping. Call it credential_keys instead.
@@clientName(Azure.AI.Projects.CustomCredential.keys,
"credential_keys",
"python"
);

// Less generic names for C# SDK (avoid one-word class names)
@@clientName(Azure.AI.Projects.Connection, "ConnectionProperties", "csharp");
@@clientName(Azure.AI.Projects.Deployment, "AssetDeployment", "csharp");
Expand Down
5 changes: 2 additions & 3 deletions specification/ai/Azure.AI.Projects/connections/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,8 @@ model CustomCredential extends BaseCredentials {
@visibility(Lifecycle.Read)
type: CredentialType.custom;

@doc("The credential type")
@visibility(Lifecycle.Read)
keys: Record<string>;
// Secret custom keys
...Record<string>;
}

#suppress "@azure-tools/typespec-azure-core/casing-style"
Expand Down
14 changes: 2 additions & 12 deletions ...ication/ai/data-plane/Azure.AI.Projects/preview/2025-05-15-preview/azure-ai-projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2242,19 +2242,9 @@
"CustomCredential": {
"type": "object",
"description": "Custom credential definition",
"properties": {
"keys": {
"type": "object",
"description": "The credential type",
"additionalProperties": {
"type": "string"
},
"readOnly": true
}
"additionalProperties": {
"type": "string"
},
"required": [
"keys"
],
"allOf": [
{
"$ref": "#/definitions/BaseCredentials"
Expand Down
14 changes: 2 additions & 12 deletions specification/ai/data-plane/Azure.AI.Projects/stable/2025-05-01/azure-ai-projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,19 +1443,9 @@
"CustomCredential": {
"type": "object",
"description": "Custom credential definition",
"properties": {
"keys": {
"type": "object",
"description": "The credential type",
"additionalProperties": {
"type": "string"
},
"readOnly": true
}
"additionalProperties": {
"type": "string"
},
"required": [
"keys"
],
"allOf": [
{
"$ref": "#/definitions/BaseCredentials"
Expand Down
14 changes: 2 additions & 12 deletions specification/ai/data-plane/Azure.AI.Projects/stable/v1/azure-ai-projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,19 +1443,9 @@
"CustomCredential": {
"type": "object",
"description": "Custom credential definition",
"properties": {
"keys": {
"type": "object",
"description": "The credential type",
"additionalProperties": {
"type": "string"
},
"readOnly": true
}
"additionalProperties": {
"type": "string"
},
"required": [
"keys"
],
"allOf": [
{
"$ref": "#/definitions/BaseCredentials"
Expand Down
Loading