cosmos: Allow the Query Pipeline to return an alternative query to execute in each request #25503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run go - azcosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
/azp run go - azcosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR ports functionality from the Rust SDK to enable the Query Pipeline to return an alternative query for each request, which is a prerequisite for implementing readmany operations.
Key changes include:
- Added new fields to
QueryRequestandQueryResultto support query overrides and request ordering - Extended the mock query engine to support configurable query request overrides
- Added comprehensive test coverage for query override scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/data/azcosmos/queryengine/cosmos_query_engine.go | Added fields for query override, request indexing, and drain mode to support alternative query execution |
| sdk/data/azcosmos/internal/mock_query_engine.go | Implemented query request configuration and request ordering validation in the mock engine |
| sdk/data/azcosmos/cosmos_container_query_engine_test.go | Added test cases for query override with/without parameters and refactored test item generation |
| sdk/data/azcosmos/cosmos_container_query_engine.go | Implemented query override logic and drain mode support in the query execution loop |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
/azp run go - azcosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azcosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
analogrelay
requested changes
Oct 27, 2025
|
/azp run go - azcosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
analogrelay
requested changes
Oct 30, 2025
|
/azp run go - azcosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
analogrelay
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting Azure/azure-sdk-for-rust#3166 as it is a pre-req for readmany.