-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add audience as valid config #46554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audience as valid config #46554
Conversation
…to tvaron3/validConfigAsAudience # Conflicts: # sdk/cosmos/azure-cosmos-spark_3-5_2-12/CHANGELOG.md
/azp run java - cosmos - spark |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for configuring custom AAD token audiences in Cosmos Spark connector by introducing the spark.cosmos.auth.aad.audience
configuration option.
Key Changes
- Added new
Audience
configuration parameter to support custom AAD token audiences - Updated all Spark version variants with consistent changelog entries
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosConfig.scala | Added Audience configuration name constant and included it in the valid configuration list |
sdk/cosmos/azure-cosmos-spark_3-5_2-12/CHANGELOG.md | Added changelog entry documenting the new audience configuration option |
sdk/cosmos/azure-cosmos-spark_3-4_2-12/CHANGELOG.md | Added changelog entry documenting the new audience configuration option |
sdk/cosmos/azure-cosmos-spark_3-3_2-12/CHANGELOG.md | Added changelog entry documenting the new audience configuration option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
For the fabric account data resolver, the spark.cosmos.auth.aad.audience needs to be a valid config.