Skip to content

Conversation

tvaron3
Copy link
Member

@tvaron3 tvaron3 commented Sep 1, 2025

Description

For the fabric account data resolver, the spark.cosmos.auth.aad.audience needs to be a valid config.

…to tvaron3/validConfigAsAudience

# Conflicts:
#	sdk/cosmos/azure-cosmos-spark_3-5_2-12/CHANGELOG.md
@github-actions github-actions bot added the Cosmos label Sep 1, 2025
@tvaron3
Copy link
Member Author

tvaron3 commented Sep 1, 2025

/azp run java - cosmos - spark

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tvaron3 tvaron3 marked this pull request as ready for review September 2, 2025 05:53
@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 05:53
@tvaron3 tvaron3 requested review from kirankumarkolli and a team as code owners September 2, 2025 05:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for configuring custom AAD token audiences in Cosmos Spark connector by introducing the spark.cosmos.auth.aad.audience configuration option.

Key Changes

  • Added new Audience configuration parameter to support custom AAD token audiences
  • Updated all Spark version variants with consistent changelog entries

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosConfig.scala Added Audience configuration name constant and included it in the valid configuration list
sdk/cosmos/azure-cosmos-spark_3-5_2-12/CHANGELOG.md Added changelog entry documenting the new audience configuration option
sdk/cosmos/azure-cosmos-spark_3-4_2-12/CHANGELOG.md Added changelog entry documenting the new audience configuration option
sdk/cosmos/azure-cosmos-spark_3-3_2-12/CHANGELOG.md Added changelog entry documenting the new audience configuration option

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvaron3 tvaron3 merged commit b362e8f into Azure:main Sep 3, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants