Skip to content

Conversation

map-blasterson
Copy link

Contributing to the Azure SDK

New api-version removes MapsSkuName.S0 which causes these tests to fail.
Updating tests to use the latest SKU.

@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 16:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Maps management plane tests to use the new 2025-10-01-preview API version. The main change is migrating from the deprecated MapsSkuName.S0 SKU to MapsSkuName.G2 after the S0 SKU was removed from the new API version.

Key changes:

  • Replace all instances of MapsSkuName.S0 with MapsSkuName.G2 in test assertions
  • Remove SKU update test logic that was testing S0 to S1 transitions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/maps/Azure.ResourceManager.Maps/tests/ScenarioTests/MapsAccountTests.cs Updates test assertions to use G2 SKU instead of deprecated S0 SKU, removes S1 SKU update test logic
sdk/maps/Azure.ResourceManager.Maps/tests/MapsManagementTestBase.cs Updates default SKU assertion in test verification helper method from S0 to G2

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management package. labels Oct 2, 2025
Copy link

github-actions bot commented Oct 2, 2025

Thank you for your contribution @map-blasterson! We will review the pull request and get back to you soon.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@map-blasterson:

Your account lacks the public GitHub organization memberships and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants