-
Notifications
You must be signed in to change notification settings - Fork 5k
[Storage] [WebJobs] Fix tests for GetBlobs changes #52987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes test failures related to changes in the Azure Storage SDK's GetBlobs method API. The changes update test code to use the new GetBlobsOptions parameter structure instead of the deprecated direct prefix parameter.
- Updates GetBlobs method call to use GetBlobsOptions object with Prefix property
- Adds necessary using statement for Azure.Storage.Blobs.Models namespace
...zure.WebJobs.Extensions.Storage.Scenario.Tests/tests/MultipleStorageAccountsEndToEndTests.cs
Outdated
Show resolved
Hide resolved
/azp run net - storage - functions |
Azure Pipelines successfully started running 1 pipeline(s). |
...zure.WebJobs.Extensions.Storage.Scenario.Tests/tests/MultipleStorageAccountsEndToEndTests.cs
Outdated
Show resolved
Hide resolved
I take this back, I had to make changes to the source code, but they're not functional/behavioral changes. They're just adjustments to the GetBlobs API call. |
/azp run net - storage - functions |
Azure Pipelines successfully started running 1 pipeline(s). |
...WebJobs.Extensions.Storage.Blobs/src/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs.csproj
Show resolved
Hide resolved
@amnguye can this be merged? |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.