Skip to content

Conversation

rajkumar-rangaraj
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 20:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements customer SDK statistics tracking functionality as part 2 of the Azure Monitor Exporter customer SDK stats feature. The implementation adds telemetry counting, success/failure tracking, and statistical reporting throughout the telemetry processing pipeline.

Key changes include:

  • Added TelemetrySchemaTypeCounter to track different telemetry types (request, dependency, exception, etc.)
  • Modified helper methods to return both telemetry items and counters as tuples
  • Updated all exporters and transmitters to pass counter information through the pipeline
  • Enhanced transmission result processing to track successes, failures, retries, and drops with detailed categorization

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
TelemetrySchemaTypeCounter.cs Renamed class from TelemetryCounter to TelemetrySchemaTypeCounter
CustomerSdkStatsHelper.cs Updated method parameters to use renamed counter class
OpenTelemetryBuilderExtensions.cs Added customer SDK stats registration and reordered imports
TraceHelper.cs Modified to return tuple with counter, added counter increment logic
MetricHelper.cs Modified to return tuple with counter for metric tracking
LogsHelper.cs Modified to return tuple with counter, added counter increment logic
ITransmitter.cs Updated interface to include counter parameter
HttpPipelineHelper.cs Enhanced with counter tracking, JSON parsing, and detailed transmission result processing
TransmitFromStorageHandler.cs Added counter tracking for storage transmission scenarios
AzureMonitorTransmitter.cs Updated to use counter parameter and track transmission outcomes
All Exporter classes Updated to handle tuple return values and pass counters
Test files Updated to handle new tuple return values and validate counter behavior

@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant