[Storage] [WebJobs] Revert "Implementing lightweight detection for new write operations" #53077
+27
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnguye
requested review from
fabiocav,
jalauzon-msft,
jaschrep-msft,
mathewc,
nickliu-msft,
seanmcc-msft and
tg-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous implementation that added lightweight detection for new write operations in the Azure Storage WebJobs extensions. The revert removes functionality that was designed to optimize blob write detection by checking metadata without fully parsing log entries.
Key changes:
- Removes the
HasBlobWritesAsyncmethod and related test infrastructure - Reverts to the original approach of using
GetRecentBlobWritesAsyncfor detecting blob writes - Removes test cases and mock infrastructure for the lightweight detection feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| BlobLogListenerTests.cs | Removes test cases for HasBlobWritesAsync method and associated mock infrastructure |
| BlobScalerMonitorProvider.cs | Reverts from lightweight HasBlobWritesAsync back to GetRecentBlobWritesAsync for write detection |
| BlobLogListener.cs | Removes the HasBlobWritesAsync method implementation and makes constructor private again |
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Listeners/BlobScalerMonitorProvider.cs
Show resolved
Hide resolved
mathewc
approved these changes
Oct 8, 2025
jalauzon-msft
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #52977