-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[Monitor] Add Metrics Query library #42113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
f9c9fe8
to
9f48896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new TypeSpec-based Azure Monitor Metrics Query library (azure-monitor-querymetrics
) to the Azure SDK for Python. The package provides functionality for querying metrics data from multiple Azure resources through the Azure Monitor service.
Key changes:
- New TypeSpec-generated client library for Azure Monitor metrics querying
- Support for both synchronous and asynchronous operations
- Comprehensive test suite with authentication, granularity, and filtering tests
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
sdk/monitor/ci.yml | Adds CI configuration for the new azure-monitor-querymetrics package |
sdk/monitor/azure-monitor-querymetrics/tsp-location.yaml | TypeSpec configuration pointing to the Monitor.Query.Metrics specification |
sdk/monitor/azure-monitor-querymetrics/tests/ | Complete test suite including sync/async client tests and test configuration |
sdk/monitor/azure-monitor-querymetrics/setup.py | Package setup configuration with dependencies and metadata |
sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/ | Core client implementation with models, utilities, and generated code |
sdk/monitor/azure-monitor-querymetrics/tests/test_metrics_client.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/aio/_client.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/_client.py
Show resolved
Hide resolved
This adds the TypeSpec-based azure-monitor-querymetrics package. Signed-off-by: Paul Van Eck <[email protected]>
9f48896
to
c1e8b3b
Compare
Signed-off-by: Paul Van Eck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use _generated
Closing in favor of #42174 |
This adds the TypeSpec-based
azure-monitor-querymetrics
package.