Skip to content

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Jul 21, 2025

This adds the TypeSpec-based azure-monitor-querymetrics package.

Copy link

github-actions bot commented Jul 21, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-monitor-querymetrics

@pvaneck pvaneck force-pushed the monitor-querymetrics-typespec branch 3 times, most recently from f9c9fe8 to 9f48896 Compare July 22, 2025 00:07
@pvaneck pvaneck marked this pull request as ready for review July 22, 2025 00:57
@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 00:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new TypeSpec-based Azure Monitor Metrics Query library (azure-monitor-querymetrics) to the Azure SDK for Python. The package provides functionality for querying metrics data from multiple Azure resources through the Azure Monitor service.

Key changes:

  • New TypeSpec-generated client library for Azure Monitor metrics querying
  • Support for both synchronous and asynchronous operations
  • Comprehensive test suite with authentication, granularity, and filtering tests

Reviewed Changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/monitor/ci.yml Adds CI configuration for the new azure-monitor-querymetrics package
sdk/monitor/azure-monitor-querymetrics/tsp-location.yaml TypeSpec configuration pointing to the Monitor.Query.Metrics specification
sdk/monitor/azure-monitor-querymetrics/tests/ Complete test suite including sync/async client tests and test configuration
sdk/monitor/azure-monitor-querymetrics/setup.py Package setup configuration with dependencies and metadata
sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/ Core client implementation with models, utilities, and generated code

This adds the TypeSpec-based azure-monitor-querymetrics package.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the monitor-querymetrics-typespec branch from 9f48896 to c1e8b3b Compare July 22, 2025 02:23
Signed-off-by: Paul Van Eck <[email protected]>
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use _generated

@pvaneck
Copy link
Member Author

pvaneck commented Jul 25, 2025

Closing in favor of #42174

@pvaneck pvaneck closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants