[Storage] [STG 100] List Blobs Flat + Hierarchal start_from
#42173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
| @@ -815,6 +815,9 @@ def list_blobs( | |||
| :keyword int results_per_page: | |||
| Controls the maximum number of Blobs that will be included in each page of results if using | |||
| `ItemPaged.by_page()`. | |||
| :keyword str start_from: Specifies the full path (inclusive) to list paths from. | |||
| For non-recursive list, only one entity level is supported. | |||
| For recursive list, multiple entity levels are supported. | |||
There was a problem hiding this comment.
Since we are in the non-recursive function we probably don't need to mention the recursive restriction. In fact, for list_blobs, we probably don't need to mention it at all.
For walk_blobs (the recursive one) we should just mention "only one entity level is supported".
| @@ -815,6 +815,9 @@ def list_blobs( | |||
| :keyword int results_per_page: | |||
| Controls the maximum number of Blobs that will be included in each page of results if using | |||
| `ItemPaged.by_page()`. | |||
| :keyword str start_from: Specifies the full path (inclusive) to list paths from. | |||
There was a problem hiding this comment.
Anything added to list_blobs should also be added to list_blob_names below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.