Fix mypy errors #42192
Merged
Fix mypy errors #42192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error handling for trunk retrieval
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
…into sofiar/Address_mypy_errors
sofiar-msft
requested review from
Arazan,
whisper6284 and
danielortega-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes MyPy type checking errors in the Azure Communication Phone Numbers SDK. The changes are primarily focused on correcting type annotations and handling potential None values that MyPy flagged as unsafe operations.
- Replaces
os.getenv()withos.environ[]in sample files to ensure non-None return types - Adds proper type checking and null safety for optional fields in client code
- Updates type annotations to include Union types for credentials and adds necessary imports
- Enables MyPy checking by removing disabled flags from pyproject.toml
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple sample files | Replace os.getenv() with os.environ[] for required environment variables |
_sip_routing_client_async.py |
Add null checks, type annotations, and proper error handling |
_sip_routing_client.py |
Add null checks, type annotations, and proper error handling |
_phone_numbers_client_async.py |
Add type casts and null safety checks |
_phone_numbers_client.py |
Add type casts and null safety checks |
_patch.py files |
Add __all__ declarations |
pyproject.toml |
Enable MyPy and type checking by removing disabled flags |
...on/azure-communication-phonenumbers/samples/browse_and_reserve_phone_numbers_sample_async.py
Outdated
Show resolved
Hide resolved
...nication/azure-communication-phonenumbers/samples/browse_and_reserve_phone_numbers_sample.py
Outdated
Show resolved
Hide resolved
...ion/azure-communication-phonenumbers/samples/browse_and_reserve_numbers_bulk_sample_async.py
Outdated
Show resolved
Hide resolved
...unication/azure-communication-phonenumbers/samples/browse_and_reserve_numbers_bulk_sample.py
Outdated
Show resolved
Hide resolved
...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py
Show resolved
Hide resolved
…wse_and_reserve_phone_numbers_sample_async.py Remove redundant initialization Co-authored-by: Copilot <[email protected]>
…wse_and_reserve_phone_numbers_sample.py Co-authored-by: Copilot <[email protected]>
…wse_and_reserve_numbers_bulk_sample_async.py Co-authored-by: Copilot <[email protected]>
…wse_and_reserve_numbers_bulk_sample.py Co-authored-by: Copilot <[email protected]>
whisper6284
reviewed
Jul 30, 2025
...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py
Outdated
Show resolved
Hide resolved
whisper6284
approved these changes
Jul 30, 2025
danielortega-msft
approved these changes
Jul 30, 2025
danielortega-msft
approved these changes
Jul 30, 2025
whisper6284
approved these changes
Jul 30, 2025
sofiar-msft
force-pushed
the
sofiar/Address_mypy_errors
branch
from
4846517 to
269f1b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi Python communication library code owners,
Please see the notice below. It is required that each client library in the Python repo run and pass static type checking with MyPy on source and sample code. The table below describes communication libraries with disabled or failing MyPy. Please take a look at the errors and actions needed and ensure each library is enabled with MyPy and passing by August 1st to avoid unexpected failures blocking releases.
azure-communication-phonenumbers
Build
Fix errors and enable mypy and type_check_samples in pyproject.toml
To view errors locally you can run the following command at the package-level:
After fixing sample typing errors, you should remove the
mypy=falseandtype_check_samples=falsefound in your library's pyproject.toml file to enable this check to run in CI.If there is anything preventing these checks from being enabled for your library, please reach out. Thanks for your help in making our libraries MyPy clean for our customers!
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines