[Monitor] Update query package to use TypeSpec #42205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
pvaneck
force-pushed
the
monitor-query-typespec-patch
branch
2 times, most recently
from
8755b5d to
34baeca
Compare
pvaneck
requested review from
joshfree,
KevinBlasko,
KarishmaGhiya,
scottaddie,
srnagar,
jairmyree and
gulopesd
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Monitor Query package to use TypeSpec for code generation, replacing the previous Autorest-based generation. The primary purpose is to modernize the code generation pipeline while maintaining compatibility and functionality for logs querying capabilities.
Key changes:
- Migration from Autorest to TypeSpec code generation
- Updates to Python version requirements (minimum Python 3.9)
- Removal of metrics-related functionality (clients, tests, and samples)
Reviewed Changes
Copilot reviewed 120 out of 120 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Specifies TypeSpec source location and commit for code generation |
| setup.py | Updates package metadata, dependencies, and Python version requirements |
| swagger/README.md | Removes Autorest configuration (replaced by TypeSpec) |
| tests/ | Removes all metrics-related test files and updates logs test imports |
| samples/ | Removes metrics-related samples and updates pylint directives |
| azure/monitor/query/ | Regenerated models, client code, and configurations using TypeSpec |
This removes Metrics-related code/content and converts this package to be for logs querying only. Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
monitor-query-typespec-patch
branch
from
34baeca to
d989633
Compare
Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricsClientandMetricsQueryClienthave been removed from theazure-monitor-querypackage. This is part of the migration to split logs and metrics functionality into separate packages and using TypeSpec as the generation tooling for this SDK.MetricsClienthas been moved to the newazure-monitor-querymetricspackage.MetricsQueryClientcan be access through theazure-mgmt-monitorpackage.