Add properties to FDP, fix changelog formatting #42208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pyrit and not remove the other one
Co-authored-by: nagkumar91 <[email protected]>
Fix client request ID header format in Azure AI evaluation generated client
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in the evaluation logging functionality and corrects changelog formatting. The main issue was that properties were being defined but not properly passed to the evaluation upload, and the changelog had duplicated "Features Added" headers.
Key changes:
- Fixed missing properties parameter in EvaluationUpload initialization
- Removed unused EVALUATION_RUN property that was referencing promptflow
- Cleaned up changelog formatting by removing duplicate headers and extra blank lines
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_utils.py |
Added properties parameter to EvaluationUpload and removed unused EVALUATION_RUN property |
sdk/evaluation/azure-ai-evaluation/CHANGELOG.md |
Fixed duplicate "Features Added" header and formatting issues |
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_utils.py
Show resolved
Hide resolved
github-actions
bot
added
the
Evaluation
singankit
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines