Rename Task Success Evaluator to Task Completion Evaluator #43190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
August 11, 2025 15:11
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @salma-elshafey! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This pull request renames the "Task Success Evaluator" to "Task Completion Evaluator" across the Azure AI Evaluation SDK. The rename affects class names, file paths, imports, and documentation to consistently use the new terminology.
Key changes:
- Renamed TaskSuccessEvaluator class to TaskCompletionEvaluator
- Updated file and directory structure to use "task_completion" naming
- Modified sample code and documentation to reflect the new class name
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_aoai_score_model_grader.py | Added skip markers to test methods |
| evaluation_samples_evaluate_fdp.py | Added sample code for TaskCompletionEvaluator |
| evaluation_samples_evaluate.py | Fixed import and added TaskCompletionEvaluator sample |
| agent_evaluation.ipynb | Removed unused import and trailing commas |
| cspell.json | Added new words and updated file paths for task_completion |
| _exceptions.py | Added TASK_COMPLETION_EVALUATOR error target |
| task_completion.prompty | New prompty file for task completion evaluation |
| _task_completion.py | New evaluator implementation for task completion |
| init.py | New module init file exporting TaskCompletionEvaluator |
| _eval_mapping.py | Added TaskCompletionEvaluator to evaluation mapping |
...ion/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_task_completion/_task_completion.py
Outdated
Show resolved
Hide resolved
...ion/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_task_completion/_task_completion.py
Outdated
Show resolved
Hide resolved
luigiw
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines