-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Rewrite Bandit Without Tox #43241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rewrite Bandit Without Tox #43241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new bandit security check tool that runs independently of tox, as part of the ongoing migration from the slower tox-based framework to a faster direct execution approach.
- Adds a new
bandit
module to perform security vulnerability scanning - Integrates the bandit check into the main CLI parser and command registration
- Updates documentation to include the new bandit command
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
eng/tools/azure-sdk-tools/azpysdk/main.py | Imports and registers the new bandit module in the CLI |
eng/tools/azure-sdk-tools/azpysdk/bandit.py | Implements the complete bandit security check functionality |
doc/tool_usage_guide.md | Documents the new bandit command usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inverted condition present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling we will want the abstraction to run with PATH prepend + VIRTUAL_ENV set. But approving if you are confident in the runs on this guy.
#42883