Added response hook to replace throughput #43243
Open
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds back the response_hook parameter to the replace_throughput methods in both synchronous and asynchronous Cosmos DB container classes, allowing users to access response metadata when replacing container throughput.
- Adds
response_hookparameter to sync and asyncreplace_throughputmethods - Includes proper documentation for the new parameter
- Implements the hook invocation after the throughput replacement operation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/azure/cosmos/container.py | Adds response_hook parameter and implementation to sync replace_throughput method |
| sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py | Adds response_hook parameter and implementation to async replace_throughput method, fixes paramtype documentation |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added response hook parameter back to replace_throughput for sync and async containers
Addressing this API follow up review item: