[Storage] put_blob_from_url for BlobClient
#2936
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
| /// `https://myaccount.blob.core.windows.net/mycontainer/myblob?snapshot=<DateTime>` | ||
| /// `https://otheraccount.blob.core.windows.net/mycontainer/myblob?sastoken` | ||
| /// * `options` - Optional configuration for the request. See [`BlockBlobClientPutBlobFromUrlOptionsExt`](crate::models::BlockBlobClientPutBlobFromUrlOptionsExt) for additional usage helpers. | ||
| pub async fn put_blob_from_url( |
There was a problem hiding this comment.
This should go on BlockBlobClient since its Block Blob specific.
| /// `https://myaccount.blob.core.windows.net/mycontainer/myblob?snapshot=<DateTime>` | ||
| /// `https://otheraccount.blob.core.windows.net/mycontainer/myblob?sastoken` | ||
| /// * `options` - Optional configuration for the request. See [`BlockBlobClientPutBlobFromUrlOptionsExt`](crate::models::BlockBlobClientPutBlobFromUrlOptionsExt) for additional usage helpers. | ||
| pub async fn put_blob_from_url( |
There was a problem hiding this comment.
Let's rename this to upload_from_url
| fn with_if_not_exists(self) -> Self; | ||
| } | ||
|
|
||
| impl BlockBlobClientPutBlobFromUrlOptionsExt for BlockBlobClientPutBlobFromUrlOptions<'_> { |
There was a problem hiding this comment.
Can we do this without an extension?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.tsp: Azure/azure-rest-api-specs#36847put_blob_from_urlcreate_test_blobutility to acceptdatabut still have a fallback for simple casesBlockBlobClientPutBlobFromUrlResultHeaders̶d̶a̶t̶e̶
content_md5
last_modified
etag
encryption_key_sha256
encryption_scope
is_server_encrypted
version_id