create_async_runtime: Make cfg checks exhaustive
#2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magodo
requested review from
heaths,
RickWinter,
ronniegeraghty and
LarryOsterman
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @magodo! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a configuration gap in the create_async_runtime() function by making the cfg checks exhaustive. The change prevents a scenario where enabling the wasm_bindgen feature but building for a non-WASM target would result in no matching configuration, causing the function to return () instead of a proper runtime.
- Made
cfgconditions mutually exclusive by adding early returns - Updated the fallback condition to properly exclude the WASM+wasm_bindgen combination
- Ensures all possible feature/target combinations are handled correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
cfgchecks exhaustive in thecreate_async_runtime(), to avoid a case that a package depending ontypespec_client_core, enabledwasm_bindgenfeature, but build for native target (e.g. x86-84). This will hit no check conditions in thecreate_async_runtime(), makes it reutrn(). Instead, this shall use the standard runtime.In fact, mutually exclusive features are not encouraged: https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features. While I don't have any better idea in this case..
Related to: #2838.