Map int types to integer in System Type to Json Type Map#3327
Open
aaronburtle wants to merge 3 commits intomainfrom
Open
Map int types to integer in System Type to Json Type Map#3327aaronburtle wants to merge 3 commits intomainfrom
aaronburtle wants to merge 3 commits intomainfrom
Conversation
aaronburtle
requested review from
Alekhya-Polavarapu,
JerryNixon,
RubenCerna2079,
rusamant,
sourabh1007,
souvikghosh04,
stuartpa and
vadeveka
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DAB’s OpenAPI JSON type mapping so CLR integral types map to the OpenAPI/JSON Schema integer type (instead of number), addressing incorrect client generation for SQL INT columns.
Changes:
- Added
JsonDataType.Integerto represent the OpenAPI/JSON Schemaintegertype. - Updated
TypeHelper’s CLR-to-JSON type map soshort/ushort/int/uint/long/ulongresolve toJsonDataType.Integer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Core/Services/TypeHelper.cs | Changes CLR integral type mapping from Number to Integer for OpenAPI schema generation. |
| src/Core/Services/OpenAPI/JsonDataType.cs | Adds the new Integer enum value used by OpenAPI schema generation. |
Open
1 task
Aniruddh25
approved these changes
Apr 4, 2026
Collaborator
|
This is an impactful bugfix so opportunistically taking it for 2.0 stable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #3324
What is this change?
Expand the enums for our json data type to include
integer. Use this new integer type in the system to json type map.How was this tested?
Existing test coverage.