Improve GraphQL naming conflict error to identify conflicting entities and operations - #3722
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot
AI
changed the title
[WIP] Fix autoentities conflict with duplicate GraphQL operations
Improve GraphQL naming conflict error to identify conflicting entities and operations
Jul 14, 2026
Contributor
|
Copilot Change the PR so that in the output message we don't include the operation names. Also, if possible we want to keep using the hashset we already used before. Try to change the logic as little as possible from what it was before the changes you made in this PR. The only change should be the error message. |
… names, remove ops from message
Contributor
Author
Done in 3a1f2d0. The changes are now minimal:
New message format: |
RubenCerna2079
marked this pull request as ready for review
August 3, 2026 19:09
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 6 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 6 pipeline(s). |
aaronburtle
reviewed
Aug 6, 2026
aaronburtle
reviewed
Aug 6, 2026
aaronburtle
approved these changes
Aug 6, 2026
aaronburtle
left a comment
Contributor
There was a problem hiding this comment.
Looks good once comments are addressed!
Aniruddh Munde (Aniruddh25)
approved these changes
Aug 7, 2026
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 6 pipeline(s). |
…-duplicate-graphql-operations' into copilot/fix-duplicate-graphql-operations
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 6 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 6 pipeline(s). |
…te-graphql-operations' into copilot/fix-duplicate-graphql-operations
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 6 pipeline(s). |
RubenCerna2079
enabled auto-merge (squash)
August 13, 2026 16:32
aaronburtle
approved these changes
Aug 13, 2026
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 6 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
When
autoentitiesincludes tables whose names differ only by singular/plural form (e.g.dbo.Categoryanddbo.Categories), DAB fails startup with a vague error that doesn't identify the other conflicting entity, the generated GraphQL names, or how to resolve the conflict.What is this change?
RuntimeConfigValidator.ValidateEntitiesDoNotGenerateDuplicateQueriesOrMutation: ReplacedHashSet<string>operation tracking withDictionary<string, string>(operation → owning entity). Checks all operations (not short-circuit) to collect every conflicting name, then builds a structured error message including:Before:
After:
How was this tested?
ValidateExceptionForDuplicateQueriesDueToEntityDefinitionshelper to verify both conflicting entity names appear in the messageValidateAutoEntitiesWithSingularPluralNameCollisionGenerateDuplicateQueriescovering the exactdbo.Category/dbo.CategoriesscenarioSample Request(s)
N/A — error message improvement only; no API behavior changes.